Hive: Do not validate payload attributes if nil or syncing and pre-cancun check #9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
reviewed
Feb 9, 2024
turbo/engineapi/engine_server.go
Outdated
| if payloadAttributes == nil || status.Status != engine_types.ValidStatus { | ||
| return &engine_types.ForkChoiceUpdatedResponse{PayloadStatus: status}, nil | ||
| } | ||
|
|
||
| if payloadAttributes != nil { |
There was a problem hiding this comment.
With this change if payloadAttributes != nil is superfluous
yperbasis
approved these changes
Feb 9, 2024
|
@racytech Have you checked the sequence of messages for the scenario - |
|
In this case we can't return both errors. one or another, whichever comes first... it happens that status check has to be first , so if it's not valid we not going to proceed to attributes validation and payload building |
racytech
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #9407